- May 27, 2020
- May 26, 2020
-
-
Paul Duffin authored
A related change is going to switch ike to using framework-module-defaults. That sets shared_library: false as most framework libraries are not intended and should not be usable as a shared library. This change ensures that ike's behavior is not changed by that switch. Bug: 156723295 Test: m nothing Change-Id: I529f6267781c7bc3197106649ea6db91db41ea9a Merged-In: I529f6267781c7bc3197106649ea6db91db41ea9a Exempt-From-Owner-Approval: minor build refactoring. (cherry picked from commit a6fbe8433a985cac0b8760f4930293ab835e3d3c)
-
- May 20, 2020
-
-
evitayan authored
This commit fixes the interoperability issue in SA negotiation to allow the following two cases: - When the request proposal has a NONE value transform, response proposal is still valid if it does not have this transform - When the request proposal does not have this transform, the response is still valid if it has a NONE value of this transform. Bug: 156757683 Test: CtsIkeTestCases, FrameworksIkeTests(new tests added) Change-Id: I1cc17b92903912a03bdb27729ab0b9db093c94b7
-
Yan Yan authored
-
Yan Yan authored
-
- May 19, 2020
-
-
Yan Yan authored
-
evitayan authored
This commit fixes the NullPointException when creating first Child is rejected by a error notification. The root cause is that when receiving a error notification, saPayload returned by ikeMessage.getPayloadForType will be null and will be passed to #handleFirstChildExchange. This commit also stops throwing fatal exception to IkeSessionStateMachine when there is a missing payload for create first Child. This will allow IKE AUTH succeed and let ChildSessionStateMachine to do the check Bug: 148287674 Test: atest testIkeAuthHandlesFirstChildCreationFail Test: atest FrameworksIkeTests Change-Id: I0f130abca20c748969b28cb7ad67de3392a3aa06
-
evitayan authored
Resolve the bug that when receiving error notify and no auth payload in IKE Auth, IKE library would still look for payloads for authentication and will throw exception saying missing payload if not found. This commit make IKE library throw the received error to user in this case Bug: 148287674 Test: atest FrameworksIkeTests(new tests added) Test: testIkeAuthHandlesAuthFailNotification testIkeAuthHandlesFirstChildCreationFail Change-Id: I7fb20fee8fdf649ccbbaef838f87b2d7cec70bc1
-
Paul Duffin authored
-
- May 15, 2020
-
-
evitayan authored
Release IPsec SPI if not receiving Create Child Response before the IKE Session is terminated. Bug: 142069689 Test: FrameworksIkeTests, CtsIkeTestCases Change-Id: I6236d7943d5eaed7d6e417a71ce2ddafb06cd0a0
-
evitayan authored
This commit releases IPsec SPIs after constructing a ChildSaRecord with it to avoid leaking SPI resources Bug: 142069689 Test: atest FrameworksIkeTests, CtsIkeTestCases Change-Id: Iacf46c0c43c2e037eb47923c41b41ad4eac143f5
-
Paul Duffin authored
Test: m update-api Bug: 155164730 Change-Id: I24d37c52b0c42bcc19948e8472cc0e76e94e2fe0 Merged-In: I24d37c52b0c42bcc19948e8472cc0e76e94e2fe0 (cherry picked from 15c4fed09b09b745603cb63090ff6a2bd3a9fdcb)
-
Treehugger Robot authored
-
- May 13, 2020
-
-
Treehugger Robot authored
-
- May 12, 2020
-
-
Yan Yan authored
-
Yan Yan authored
-
Paul Duffin authored
In preparation for enabling API lint checking on java_sdk_library adds lint-baseline.txt containing all the existing issues for these APIs. Bug 156141473 tracks the work to clean up the issues found by lint. Bug: 156126315 Bug: 156141473 Test: m checkapi Change-Id: Ia270eb432fb5e35985d90b238770521101d986b9 Merged-In: Ibae815c48d55b6eb17eeb599e891bf291df42ffb
-
evitayan authored
Fix the bug that the outbound fragment integrity checksum is not correct Bug: 156306543 Test: FrameworksIkeTests. CtsIkeTestCases Test: Manually test against Strongswan server Change-Id: I6b3ce36cd36bf9f1d79fc22b22f0ce7a70b3ed2e
-
- May 11, 2020
-
-
evitayan authored
Delete #getAddress in DNS and DHCP requests because they are not used and they will break SignatureMultiLibsTest#testSignature Bug: 155554736 Test: FrameworksIkeTests, CtsIkeTestCases Test: SignatureMultiLibsTest#testSignature (on git_master) https://android-build.googleplex.com/builds/tests/view?invocationId=I94500004335875259&testResultId=TR81408013381341802 Change-Id: I25a8625dd9907649f24f0c5cd0fb935ad76fcea4
-
- May 08, 2020
-
-
evitayan authored
Bug: 122532266 Test: atest FrameworksIkeTests (new tests added) Change-Id: Id8c1f81f324283a5f9d556a977df060fa63c2139
-
- May 05, 2020
-
-
Treehugger Robot authored
-
Benedict Wong authored
This change adds a wakelock to ensure that the device does not go to sleep in the middle of an exchange. Otherwise, the IKE session will be left in a non-deterministic state Bug: 152236790 Test: FrameworkIkeTests passing Change-Id: Ia57bb27ac75891cb47237596580792d58bfaf693 Merged-In: Ia57bb27ac75891cb47237596580792d58bfaf693
-
Anton Hansson authored
-
- May 04, 2020
-
-
Yan Yan authored
* changes: Use AlarmManager to trigger rekey Reschedule rekey in rekey state instead of TempFailureHandler
-
Dheeraj Shetty authored
Test: atest FrameworksIkeTest Bug: 138965374 Change-Id: I7765379fd58ab3640db47f7fa6fd7e2149dc0f85 Merged-In: I7765379fd58ab3640db47f7fa6fd7e2149dc0f85
-
- May 02, 2020
-
-
evitayan authored
This commit uses alarm mamager to schedule rekey instead of using handler. Bug: 149058810 Test: atest FrameworksIkeTests Change-Id: I370ecc858cbf1935d55b3f9b6fffbc4e48b5eed5 Merged-In: I370ecc858cbf1935d55b3f9b6fffbc4e48b5eed5
-
- May 01, 2020
-
-
Treehugger Robot authored
-
evitayan authored
This commit does not schedule retry in TempFailureHandler anymore but in the current state. Reason is that some events like rekey should be scheduled by AlarmManager instead of in the handler. This commit: - Adds a method stub #rescheduleRekey in SaRecord - Schedule rekey retry in rekey state This CL is a preparation CL before we can switch to use alarm manager to schedule the initial rekey and rekey retry. Bug: 149058810 Test: atest FrameworksIkeTests Change-Id: If4bbf9c889f130308839c4aa57334951a78f60dd Merged-In: If4bbf9c889f130308839c4aa57334951a78f60dd
-
Dheeraj Shetty authored
DH group is absent from SA proposal during rekey of first child. In this case add it from the child session params. Test: atest FrameworksIkeTest Bug: 138965374 Change-Id: I0284516b555917f723d8bbed50beb9f23869ed1b Merged-In: I0284516b555917f723d8bbed50beb9f23869ed1b
-
Yan Yan authored
-
Benedict Wong authored
This commit switches IKE sockets from the packet reader to using a poll loop for the following reasons: 1. PacketReader FD_EVENT notifications were sometimes not fired 2. This results in flaky behavior of IKE socket reads 2. a. Even in real life, it appears as network packet loss, and may end up missing all retransmitted responses. Once packet reader is fixed, this patch should be reverted. Bug: 148689509 Test: CTS tests passing Change-Id: Iaa999cf2094768d9fd61b90ceb11fd7a23d501fc
-
- Apr 30, 2020
-
-
Anton Hansson authored
This makes the filenames of the disted artifacts (api txts and stubs) match the module name of the modules they're from. This matches the naming scheme used by java_sdk_library, which should make the future transition to this build rule easier. Bug: 149293194 Test: lunch sdk_phone_armv7 && m sdk dist && find out/dist/apistubs Change-Id: If0e181349b8b263e22e424640ea3e956b944f460 Merged-In: If0e181349b8b263e22e424640ea3e956b944f460 (cherry picked from commit 2619608a0695d130d844965e7f09885dc3484fbf)
-
Yan Yan authored
-
- Apr 29, 2020
-
-
Dheeraj Shetty authored
As per RFC 7296, protocol ID field must be ignored when when SPI field is empty. Test: atest FrameworksIkeTest Test: On device test, to check if IKE INIT fails on wrong protocol ID. Bug: 154554731 Change-Id: I65d72ee4194823615d27d85f56c732dcd98047e9 Change-Id: I28c930a66d56c1153d911cceed105ce0052764e4
-
- Apr 27, 2020
-
-
evitayan authored
Fix the bug that using hasCapability to check if the network is a test network Bug: 148689509 Test: atest FrameworksIkeTests Test: manually tested Change-Id: Iadde414a0cc4575666d65a1002c6ab8b58ac9d86
-
- Apr 26, 2020