Skip to content
Snippets Groups Projects
  1. May 27, 2020
  2. May 26, 2020
    • Paul Duffin's avatar
      Ensure ike works as a shared library · 3fadfb2b
      Paul Duffin authored
      A related change is going to switch ike to using
      framework-module-defaults. That sets shared_library: false as most
      framework libraries are not intended and should not be usable as a
      shared library. This change ensures that ike's behavior is not changed
      by that switch.
      
      Bug: 156723295
      Test: m nothing
      Change-Id: I529f6267781c7bc3197106649ea6db91db41ea9a
      Merged-In: I529f6267781c7bc3197106649ea6db91db41ea9a
      Exempt-From-Owner-Approval: minor build refactoring.
      (cherry picked from commit a6fbe8433a985cac0b8760f4930293ab835e3d3c)
      3fadfb2b
  3. May 20, 2020
  4. May 19, 2020
    • Yan Yan's avatar
    • evitayan's avatar
      Fix NullPointException in creating first Child · 778f73f9
      evitayan authored
      This commit fixes the NullPointException when creating first
      Child is rejected by a error notification. The root cause is
      that when receiving a error notification, saPayload returned
      by ikeMessage.getPayloadForType will be null and will be
      passed to #handleFirstChildExchange.
      
      This commit also stops throwing fatal exception to
      IkeSessionStateMachine when there is a missing payload
      for create first Child. This will allow IKE AUTH succeed and
      let ChildSessionStateMachine to do the check
      
      Bug: 148287674
      Test: atest testIkeAuthHandlesFirstChildCreationFail
      Test: atest FrameworksIkeTests
      Change-Id: I0f130abca20c748969b28cb7ad67de3392a3aa06
      778f73f9
    • evitayan's avatar
      Don't throw missing payload exception if Auth is rejected with error notify · 712cb8ae
      evitayan authored
      Resolve the bug that when receiving error notify and no auth payload
      in IKE Auth, IKE library would still look for payloads for
      authentication and will throw exception saying missing payload if
      not found. This commit make IKE library throw the received error to
      user in this case
      
      Bug: 148287674
      Test: atest FrameworksIkeTests(new tests added)
      Test: testIkeAuthHandlesAuthFailNotification
            testIkeAuthHandlesFirstChildCreationFail
      Change-Id: I7fb20fee8fdf649ccbbaef838f87b2d7cec70bc1
      712cb8ae
    • Paul Duffin's avatar
      73506b58
  5. May 15, 2020
  6. May 13, 2020
  7. May 12, 2020
  8. May 11, 2020
  9. May 08, 2020
  10. May 05, 2020
  11. May 04, 2020
  12. May 02, 2020
    • evitayan's avatar
      Use AlarmManager to trigger rekey · e2a5da6e
      evitayan authored
      This commit uses alarm mamager to schedule rekey instead of using
      handler.
      
      Bug: 149058810
      Test: atest FrameworksIkeTests
      Change-Id: I370ecc858cbf1935d55b3f9b6fffbc4e48b5eed5
      Merged-In: I370ecc858cbf1935d55b3f9b6fffbc4e48b5eed5
      e2a5da6e
  13. May 01, 2020
    • Treehugger Robot's avatar
      5c216abb
    • evitayan's avatar
      Reschedule rekey in rekey state instead of TempFailureHandler · edd48e6e
      evitayan authored
      This commit does not schedule retry in TempFailureHandler anymore
      but in the current state. Reason is that some events like rekey
      should be scheduled by AlarmManager instead of in the handler.
      This commit:
      - Adds a method stub #rescheduleRekey in SaRecord
      - Schedule rekey retry in rekey state
      
      This CL is a preparation CL before we can switch to
      use alarm manager to schedule the initial rekey and rekey retry.
      
      Bug: 149058810
      Test: atest FrameworksIkeTests
      Change-Id: If4bbf9c889f130308839c4aa57334951a78f60dd
      Merged-In: If4bbf9c889f130308839c4aa57334951a78f60dd
      edd48e6e
    • Dheeraj Shetty's avatar
      Add DH groups from child session params · 1192340f
      Dheeraj Shetty authored
      DH group is absent from SA proposal during rekey of first child.
      In this case add it from the child session params.
      
      Test: atest FrameworksIkeTest
      Bug: 138965374
      Change-Id: I0284516b555917f723d8bbed50beb9f23869ed1b
      Merged-In: I0284516b555917f723d8bbed50beb9f23869ed1b
      1192340f
    • Yan Yan's avatar
      Merge "Switch IKE Sockets to use a poll loop" · 506bee6f
      Yan Yan authored
      506bee6f
    • Benedict Wong's avatar
      Switch IKE Sockets to use a poll loop · 16de8ea2
      Benedict Wong authored
      This commit switches IKE sockets from the packet reader to using a poll
      loop for the following reasons:
      1. PacketReader FD_EVENT notifications were sometimes not fired
      2. This results in flaky behavior of IKE socket reads
      2. a. Even in real life, it appears as network packet loss, and may
            end up missing all retransmitted responses.
      
      Once packet reader is fixed, this patch should be reverted.
      
      Bug: 148689509
      Test: CTS tests passing
      Change-Id: Iaa999cf2094768d9fd61b90ceb11fd7a23d501fc
      16de8ea2
  14. Apr 30, 2020
    • Anton Hansson's avatar
      Rename module dist files · 99f67e8f
      Anton Hansson authored
      This makes the filenames of the disted artifacts (api txts and stubs)
      match the module name of the modules they're from. This matches the
      naming scheme used by java_sdk_library, which should make the future
      transition to this build rule easier.
      
      Bug: 149293194
      Test: lunch sdk_phone_armv7 && m sdk dist && find out/dist/apistubs
      Change-Id: If0e181349b8b263e22e424640ea3e956b944f460
      Merged-In: If0e181349b8b263e22e424640ea3e956b944f460
      (cherry picked from commit 2619608a0695d130d844965e7f09885dc3484fbf)
      99f67e8f
    • Yan Yan's avatar
      a7906008
  15. Apr 29, 2020
    • Dheeraj Shetty's avatar
      Do not throw exception for wrong protocol ID · 8cf110e3
      Dheeraj Shetty authored
      As per RFC 7296, protocol ID field must be ignored when
      when SPI field is empty.
      
      Test: atest FrameworksIkeTest
      Test: On device test, to check if IKE INIT fails on wrong
      protocol ID.
      Bug: 154554731
      Change-Id: I65d72ee4194823615d27d85f56c732dcd98047e9
      
      Change-Id: I28c930a66d56c1153d911cceed105ce0052764e4
      8cf110e3
  16. Apr 27, 2020
    • evitayan's avatar
      Use #hasTransport to check if test network is used · 2cde5cd1
      evitayan authored
      Fix the bug that using hasCapability to check if the network is
      a test network
      
      Bug: 148689509
      Test: atest FrameworksIkeTests
      Test: manually tested
      Change-Id: Iadde414a0cc4575666d65a1002c6ab8b58ac9d86
      2cde5cd1
  17. Apr 26, 2020
Loading