- Aug 18, 2021
-
-
Jakub Czapiga authored
Change assignments from lazy to immediate to make them more deterministic. Remove unused `CUSTOM_MUSIC=n` argument from vboot build recipe. BUG=none TEST=sudo USE=abi_x86_32 emerge dev-util/cmocka && \ make clean-unit-tests && make unit-tests BRANCH=none Signed-off-by:Jakub Czapiga <jacz@semihalf.com> Change-Id: Ic746dadd5c90fb00c9c4cc974e7f212713b49224 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3100145 Reviewed-by:
Yu-Ping Wu <yupingso@chromium.org> Commit-Queue: Yu-Ping Wu <yupingso@chromium.org>
-
David Wu authored
BUG=b:193052432 TEST=emerge-brya depthcharge BRANCH=none Signed-off-by:
David Wu <david_wu@quanta.corp-partner.google.com> Change-Id: Iee27114ce56f55b0901aee365742e615b0d49bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3099147 Reviewed-by:
YH Lin <yueherngl@chromium.org> Reviewed-by:
Tim Wawrzynczak <twawrzynczak@chromium.org>
-
V Sowmya authored
This patch adds the Soundwire driver for MAX98373 codec, * Create new structure for Soundwire Max98373 codec. * Functions to enable the codec, generate the beep via tone generator. * Send the commands to program the MAX98373 registers to turn on the Tone generator in the codec. BUG=b:151514169 BRANCH=none TEST=Build and test boot beep on volteer and brya. Signed-off-by:
V Sowmya <v.sowmya@intel.com> Signed-off-by:
Sugnan Prabhu S <sugnan.prabhu.s@intel.com> Change-Id: Ic7465975f6dddc5467e302a531542e0656f7b00d Signed-off-by:
-
- Aug 17, 2021
-
-
Martin Roth authored
Treeya360 needed some additional SKU IDs - they were assigned the range between 0xB8 & 0xBF. This identifies those IDs as Treeya. BUG=b:185972050 TEST=Build. OEM will test functionality. Change-Id: I91c92a5b8e66614c23b0b03d7c21d16df3467fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3092413 Tested-by:
Kevin Chang <kevin.chang@lcfc.corp-partner.google.com> Reviewed-by:
Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Auto-Submit: Martin Roth <martinroth@google.com>
-
- Aug 16, 2021
-
-
Yu-Hsuan Hsu authored
Enable bit-bang dev beep for the second source speaker amp MAX98360. BUG=b:191713025 BRANCH=none TEST=Tested on alc1019 Signed-off-by:
Karthikeyan Ramasubramanian <kramasub@chromium.org>
-
- Aug 13, 2021
-
-
allen.cheng authored
treeya360 skuid to support ALC5682: 0xbe and 0xbf BUG=b:185972050 BRANCH=none TEST=emerge-grunt coreboot Signed-off-by:
allen.cheng <allen.cheng@lcfc.corp-partner.google.com> Change-Id: Ifda81fd41ceefb5bb439d2f22c54e2020ffd4270 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3088670 Reviewed-by:
Martin Roth <martinroth@google.com> Commit-Queue: Martin Roth <martinroth@google.com> Tested-by:
-
Jakub Czapiga authored
Use objcopy to make libpayload.a mockable. Also remove direct use of libc.a (from libpayload), as it is already contained in libpayload.a. BUG=b:196191899 TEST=sudo USE=abi_x86_32 emerge dev-util/cmocka && \ make clean-unit-tests && make unit-tests BRANCH=none Signed-off-by:Jakub Czapiga <czapiga@google.com> Commit-Queue: Yu-Ping Wu <yupingso@chromium.org> Reviewed-by:
-
Yu-Ping Wu authored
When running `make clean` without setting environment variable "KCONFIG_AUTOHEADER", a new file "config.h" will be generated under depthcharge's root directory. Therefore, pass --header-path to genconfig to explicitly specify the generated header path. BUG=none TEST=make clean; git status BRANCH=none Change-Id: I8fbf67423e9450dd51ab3115fc8b49300b9567c6 Signed-off-by:
Jack Rosenthal <jrosenth@chromium.org>
-
Yu-Ping Wu authored
The "silentoldconfig" target has been removed in CL:3026958. As explained in https://lkml.org/lkml/2011/8/31/189 , silentoldconfig is a historical misnomer, nowadays oldconfig is silent as well. Therefore, replace silentoldconfig with oldconfig. BUG=b:172343578 TEST=rm build/ -rf; make unit-tests BRANCH=none Change-Id: Iaf036fd0fd288757b685705e5a079e69f22ec2ca Signed-off-by:
Julius Werner <jwerner@chromium.org>
-
- Aug 12, 2021
-
-
Raul E Rangel authored
Currently the established pattern of adding PCI SDHCI controllers is: if (pci_find_device(GENESYS_PCI_VID, GL9755S_PCI_DID, &pci_dev)) sd = new_pci_sdhci_host(pci_dev, SDHCI_PLATFORM_REMOVABLE, 0, 0); This has two downsides: 1) It violates the depthcharge philosophy that we only access hardware when it's about to be used. 2) pci_find_device is very slow on the zork platform. It takes 7ms. This is due to the fact that the PCI devices on the buses enter low power mode. The Genesys SDHCI controller has a 3ms PortTPowerOnTime with a 4uS sleep time. So it quickly adds up when scanning the bus multiple times. This change adds a new method of adding SDHCI controllers. It defers any probing until the device is actually needed. This means that for removable SDHCI controllers, they never get accessed in normal mode. probe_pci_sdhci_host can also accept a bridge device and the first device connected will be checked. This is exactly how new_nvme_ctrlr works. It saves on having to scan the entire PCI space looking for a specific VID/DID. I created a sdhci_pci_table with vid/did pairs so we can reduce the duplication across the boards. This way we can centralize all the quirks. BUG=b:179303870, b:171470014 BRANCH=zork TEST=Boot ezkinil and verify SD card still functions Logs show: > Found SDHCI 17a0:9750 at 2:0.0 Signed-off-by:Raul E Rangel <rrangel@chromium.org> Change-Id: Ife2fd883dec8b41bf198324fbc25c31579a41e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2676807 Reviewed-by:
Mathew King <mathewk@chromium.org> Reviewed-by:
Rob Barnes <robbarnes@google.com> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
-
Yu-Ping Wu authored
The current code char *_eheap = _heap + sizeof(_heap); sets the "value" of the _eheap pointer. However, to work with libpayload's libc/malloc.c it is the "address" of _eheap that needs to be set. Add TEST_SYMBOL() and TEST_REGION() macros to tests/test.h. Fix heap declaration by using TEST_SYMBOL(heap, size). BUG=b:172343578 TEST=make unit-tests BRANCH=none Change-Id: I34f96ea4565cb06dee0b2a46c0a0ff44a597182e Signed-off-by:
-
- Aug 11, 2021
-
-
YH Lin authored
BUG=b:193527706 TEST=emerge-brya depthcharge BRANCH=none Signed-off-by:
caveh jalali <caveh@chromium.org>
-
- Aug 10, 2021
-
-
Tim Wawrzynczak authored
BUG=b:193527706 TEST=new_variant_fulltest.sh brya0 Signed-off-by:
Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by:
Furquan Shaikh <furquan@chromium.org>
-
Tim Wawrzynczak authored
This patch attempts to make it simpler to provision a new variant based on the brya reference platform. It does this by: 1) Variants provide a CONFIG_VARIANT_NAME (brya0, gimble, primus, etc.) 2) Variant-specific setup callbacks go into src/board/brya/${CONFIG_VARIANT_NAME}.c BUG=b:193527706 TEST=emerge-brya depthcharge Cq-Depend: chrome-internal:4038428 Cq-Depend: chrome-internal:4034629 Cq-Depend: chrome-internal:4038429 Cq-Depend: chrome-internal:4037958 Cq-Depend: chrome-internal:4038430 Signed-off-by: -
Yu-Ping Wu authored
Move "--ignore=MACRO_WITH_FLOW_CONTROL" to .checkpatch.conf. BUG=none TEST=repo upload . BRANCH=none Change-Id: Id6dd5d194e924ba42e46aaae2226cd274c7c67b0 Signed-off-by:
Hung-Te Lin <hungte@chromium.org>
-
- Aug 09, 2021
-
-
Bernardo Perez Priego authored
BUG=None TEST=Connect Type C pendrive containing OS image. Boot device while pressing Ctrl+u. Device must boot from USB. Signed-off-by:Bernardo Perez Priego <bernardo.perez.priego@intel.com> Change-Id: I13886b4f8bca713a270367af5c5c0d292e451e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2982530 Reviewed-by:
Bernardo Perez Priego <bernardo.perez.priego@intel.corp-partner.google.com> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org> Tested-by:
-
Tim Wawrzynczak authored
Now that each build target will end up with its own FW_CONFIG, it may be easier to manage variant creation if the common board setup is done in board.c, and each variant handles their specific setup code in a board-specific variant.c file or similar. This can be accomplished by adding some logic to the Makefile to add only variant-specific files to the build. BUG=b:193527706 TEST=Test patchtrain Signed-off-by:
-
- Aug 07, 2021
-
-
Tim Wawrzynczak authored
This changes adapts the intel_tcss API to a more typical depthcharge style with register_*()-style functions and INIT_FUNC() when appropriate. TEST=brya still boots into type-c flash drive Signed-off-by:
-
- Aug 04, 2021
-
-
Karthikeyan Ramasubramanian authored
new_jasperlake_gpio_output function saves the GPIO configuration from coreboot, resets it to the default state and register a cleanup function to restore to the coreboot initialized state before jumping to kernel. Sometime the drivers in depthcharge eg. gpio based amplifiers need to use the configuration from coreboot and just toggle the TX State. Update the function to perform the same. BUG=b:193611223, b:194120188 BRANCH=Dedede TEST=Build and boot to OS in Storo. Ensure that the GPIO Pad configuration is retained from coreboot. Ensure that the developer mode boot beep is observed. Change-Id: I687740ea181bb597f936711cbe3d3f94e497a8a9 Signed-off-by:
Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3050515 Tested-by:
-
Taniya Das authored
Add GPIO pin details specific to SC7280 chipset for the consumers to be able to request for the gpio functionality as per their requirement. BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board Signed-off-by:
Taniya Das <tdas@codeaurora.org> Change-Id: Ia774511cc68bed9d24b00d7d636e233a91ed3998 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2959255 Reviewed-by:
Shelley Chen <shchen@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by:
-
Taniya Das authored
Add common gpio functionalities across qualcomm soc targets. This common gpio driver would allow the consumers to be able to set/get gpio direction as input/output and query the gpio irq status. The GPIO pin definition would be SoC specific. Add GPIO pin details specific to SC7180 chipset for the consumers to be able to request for the gpio functionality as per their requirement. BUG=b:182963902 TEST=Validated on qualcomm sc7180 and sc7280 development board Signed-off-by:
-
- Jul 29, 2021
-
-
Sheng-Liang Pan authored
Add support for ps8805 A3 (device id: 0x0002) firmware update BUG=b:193099851 BRANCH=none TEST=emerge-trogdor depthcharge Change-Id: I837f57df7bafcf70e3aed435f4b1a23ad8845c2f Signed-off-by:
Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3047550 Reviewed-by:
Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
-
- Jul 28, 2021
-
-
Shelley Chen authored
Piglin uses SPI for TPM while herobrine will use I2C. Splitting piglin into a separate defconfig for this. BUG=b:194306888 BRANCH=None TEST=None Signed-off-by:
Shelley Chen <shchen@google.com> Change-Id: I2a4c8e0a553e4411ba1bc9de5afc49dbd38ab396 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3058861 Reviewed-by:
Bob Moragues <moragues@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by:
-
- Jul 26, 2021
-
-
Simon Shields authored
This CL adds support for slots in fastboot. Since a device's partition table is fairly flexible, we can't rely on a particular partition label being 'a' or 'b'. Instead, each kernel partition (with the CrOS kernel GUID) is treated as a separate 'slot', and the client can run `fastboot oem get-kernels` to view the mapping of slot -> partition. Bug: fuchsia:76065 Test: fastboot oem get-kernels Test: fastboot set_active a && fastboot oem get-kernels && fastboot set_active b && fastboot oem get-kernels shows changed slot. Test: fastboot getvar slot-count Change-Id: Iceb8e83e55ef76509da829e23ae17b65e82c9225 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2873314 Commit-Queue: Simon Shields <simonshields@google.com> Tested-by:Simon Shields <simonshields@google.com> Reviewed-by:
-
Simon Shields authored
This CL implements disk operations in fastboot mode, namely flashing and erasing partitions. Bug: fuchsia:76065 Test: fastboot erase KERN-A causes KERN-A to stop booting. Test: fastboot flash KERN-A <kernel> makes KERN-A boot again. Test: artifically lower FB_MAX_DOWNLOAD_SIZE (say to 1MB), verify that flashing still works. Change-Id: I127cba4e3a5fd01719ccf2ca4b46911ab328bba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2873313 Reviewed-by:
-
- Jul 22, 2021
-
-
Karthikeyan Ramasubramanian authored
In prior board versions, EC_IN_RW is not routed to AP and hence it was installed. Starting board version 3, the signal is routed to GPIO_91 and is going to be exported by coreboot. So for prior board versions, replace the ECINRW flag to keep things simple at coreboot. BUG=None BRANCH=None TEST=Build and boot to OS in Guybrush. Ensure that the system boots fine in both recovery and normal modes. Change-Id: I5ba04658dbcd640b47e2e55b0d3c442fd1b04967 Signed-off-by:
-
- Jul 21, 2021
-
-
V Sowmya authored
This patch moves the MAX98373 registers to common hearder file max98373_common_regs.h which will be used by both the I2S and soundwire MAX98373 driver. Signed-off-by:
-
Yu-Ping Wu authored
The dependency file, generated by: $(HOSTCC) ... -MMD -MT $@ -c $< -o $@.orig is determined by replacing the suffix of "$@.orig" with ".d", resulting in "$@.d" (which is *.o.d). However, when including these files by -include $(DEPENDENCIES) *.d is expected. Correct the file suffix by explicitly passing the "-MF" option to specify the path. BUG=b:172343578 TEST=make unit-tests; find build/tests/ -name "*.d" BRANCH=none Change-Id: If14426f4a8bb61e0c25be71e2d2b60a1c6eee390 Signed-off-by:
-
Yu-Ping Wu authored
Unlike in coreboot, in depthcharge we need to explicitly include config.h in Makefiles. Therefore, instead of adding test-specific config directory to search path, include the config file directly. BUG=b:172343578 TEST=make unit-tests BRANCH=none Change-Id: Ica2d1d470f9160f5dc072ec4e5d50e0194eb64fa Signed-off-by:
-
Sugnan Prabhu S authored
sndw_sendwack use a memory pointer instead of an opaque value. Fixes: a912153e ("tree wide: Use pointer for register space") Change-Id: I720f97af7d2d70f1cb4dd90dfd1bcdd60cccdbd0 Signed-off-by:
-
- Jul 20, 2021
-
-
Shelley Chen authored
As senor is not a variant of herobrine, it will need its own defconfig file. BUG=b:182963902 BRANCH=None TEST=emerge-senor depthcharge chromeos-bootimage verify that there is an image.bin file created. Change-Id: I06ba00329aedf5638b8ee04ad14e729b62b32600 Signed-off-by: -
Thejaswani Putta authored
This patch enables the config EC_VBOOT_SUPPORT to support EC SW Sync in depthcharge. BRANCH=none BUG=none TEST=Build and boot to OS on adlrvp_m. Check that EC software sync is performed in depthcharge when Vboot early EC sync disabled in coreboot. when vboot early EC sync is enabled in coreboot, in depthcharge look for the message that says ec sync performed, hence skipping. Signed-off-by:
Thejaswani Putta <thejaswani.putta@intel.corp-partner.google.com> Change-Id: I33646efc470b31a4de32f8b4964060ac35e011e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3010619 Tested-by:
Thejaswani Putta <thejaswani.putta@intel.com> Tested-by:
Selma Bensaid <selma.bensaid@intel.com> Reviewed-by:
-
- Jul 16, 2021
-
-
Hsuan Ting Chen authored
Config DIAGNOSTIC_UI is passed to vboot to enable either diag_payload or minidiag. For diag_payload: It is for a diagnostic tool which based on legacy UI and deprecated. For minidiag: Mini-diag is set default enabled for newer devices, and we could still use (vboot) kernel secdata in runtime if we decide to disable it on certain platforms. In conclusion, deprecating DIAGNOSTIC_UI will not affect newer devices. BUG=b:190796342, b:181931817 BRANCH=none TEST=emerge-volteer depthcharge Cq-Depend: chromium:3006114, chromium:3005643 Signed-off-by:
Hsuan Ting Chen <roccochen@chromium.org> Change-Id: I7690666f6456c1bf85e35937acf089e72fbf270f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3004223 Reviewed-by:
-
Hsuan Ting Chen authored
Remove CONFIG_DIAGNOSTIC_UI in defconfig and make it default enabled BUG=b:190796342 BRANCH=none TEST=build locally Signed-off-by:
-
- Jul 15, 2021
-
-
Yu-Ping Wu authored
After USB initialization, assert GPIO AP_XHCI_INIT_DONE to notify EC to enable USB VBUS when xHCI is initialized. BUG=b:193499785 TEST=emerge-cherry depthcharge BRANCH=none Change-Id: Ie5f33c28eedf0e380cffe77e2bd5ae1a085af23c Signed-off-by:
-
Yu-Ping Wu authored
Use correct names from schematics when programming GPIO. BUG=none TEST=emerge-cherry depthcharge BRANCH=none Change-Id: Id78639c3e39441e02a6149c69aa403aa303ba7f1 Signed-off-by:
-
- Jul 14, 2021
-
-
MAULIK V VAGHELA authored
Enable INTEL_TCSS and INTEL_PMC drivers, and add the table which maps Type-C ports to their corresponding USB2 and USB3 ports. Changes are being ported from Brya and USB mapping has been updated as per schematics BUG=None BRANCH=none TEST=boot adlrvp board with the changes Signed-off-by:
MAULIK V VAGHELA <maulik.v.vaghela@intel.corp-partner.google.com> Change-Id: I0fafa77a7770a21de8151ec5f91b65e117b24e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/3005770 Reviewed-by:
Meera Ravindranath <meera.ravindranath@intel.com> Reviewed-by:
-
Tim Wawrzynczak authored
Since sound_set_ops() is called twice with the intent to support gimble, the brya target doesn't boot, therefore split brya apart into brya and gimble. BUG=b:193497001 BRANCH=none TEST=boot brya Change-Id: I7287b8780110cbaac9f7eea4f80dcb3a6b65ba0c Signed-off-by:
Zhuohao Lee <zhuohao@chromium.org>
-
- Jul 13, 2021
-
-
Simon Shields authored
This is half of what's needed to write images to the disk. This CL implements logic for handling longer data transfers, which end up being split across multiple TCP packets. This gives a transfer speed of around 3MB/s (without NDEBUG and with FB_TRACE_IO disabled). Bug: fuchsia:76065 Test: fastboot flash KERN-A <some file> successfully transfers data. Change-Id: I00e2660c9fa77c02fb775cfb890355e6ac6b2449 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2873312 Reviewed-by:
-
Simon Shields authored
Currently supported variables are: - max-download-size - product - secure - version Bug: fuchsia:76065 Test: fastboot getvar product Test: fastboot getvar all Change-Id: I0af4a42ed37de27d759912d6cf8da7ddd1b9f22f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+/2873311 Reviewed-by:
-
