Unlike MODULES_OPTIONS in build.sh, modules_options in
Kleaf points to a file that contains the lines.

Fix comments and build rules that previously assume
it contains strings.

Test: bazel test //common:kernel_aarch64_tests
Fixes: 241162984
Change-Id: Ie3ab2544f91cbcec55e5af390fc06eba400add14

Use a for loop instead of find+exec so that, if there are any
errors in sign-file (e.g. the script does not exist), exits
properly (assuming set -e).

Test: manual
Change-Id: Icf04d37c3bd546a3067bb8739928246445128012
Signed-off-by: Yifan Hong <elsk@google.com>

Instead of having one filegroup named additional_artifacts_downloaded,
define multiple filgroups that corresponds to each item in it,
then define the overarching _additional_artifacts_downloaded
on top of it.

Same for _additional_artifacts_download_or_build.

Test: bazel build --use_prebuilt_gki=xxx \
  //common:kernel_aarch64_additional_artifacts_downloaded

Change-Id: I4f94fb715be32d7144e823a5f2cd02aa665d4e1e
Signed-off-by: Yifan Hong <elsk@google.com>

The source_package_name is useless because Bazel is okay
with or without the prefixing colon.

Test: TH
Change-Id: I147800c6effd6d2f417a54fb1a98a1820d1306e7
Signed-off-by: Yifan Hong <elsk@google.com>

Make it consistent with the type.

Test: TH

Change-Id: I02483692145c3609cddda42d07cdbcf80d339de3
Signed-off-by: Yifan Hong <elsk@google.com>

It is a per-branch configuration. Hence there is no
need to maintain a common list in build/kernel.

Test: TH

Change-Id: I7d2dacbf1a9579ba11e61f5db38361aaed686fab
Signed-off-by: Yifan Hong <elsk@google.com>

Test: TH

Change-Id: I9c242115f3d7c1d2a96328b1aeaaba8320d0149a
Signed-off-by: Yifan Hong <elsk@google.com>

The filesystem format is an implementation detail.

Test: none
Change-Id: I241b038760b6d5bdb9104f0282cadb601a500110

William McVicker authored 2 years ago and William McVicker committed 2 years ago

When updating the ABI symbol list for a mixed build configuration,
build_abi.sh disables mixed building and directly compiles the kernel
using the device BUILD_CONFIG. In order to be able to successfully do
this, we need to also make sure the proper kernel files are copied over
to the DIST_DIR (since mixed building doesn't require the device
BUILD_CONFIG to do this). Re-work this logic to (1) only modify
MAKE_GOALS and FILES when mixed building is enabled and (2) append the
necessary kernel artifacts to the FILES variable.

Bug: 239094500
Signed-off-by: Will McVicker <willmcvicker@google.com>
Change-Id: If1f1d60874ba899f4f8e50394b9eb653a1f7cef9

William McVicker authored 2 years ago and William McVicker committed 2 years ago

Currently we are just checking if TRIM_NONLISTED_KMI is set and not
differentiating between =0 and =1. So update the script accordingly to
make sure we don't re-compile the kernel unnecessarily.

Bug: 239094500
Signed-off-by: Will McVicker <willmcvicker@google.com>
Change-Id: I9ad799305d2790ca763bdea7a4bee1db7d24e0f0

William McVicker authored 2 years ago and William McVicker committed 2 years ago

This is needed for use of rel_path in the BUILD_CONFIG when updating the
ABI.

Bug: 239094500
Signed-off-by: Will McVicker <willmcvicker@google.com>
Change-Id: Id4880214c4d5ef7200029f770814e18c536661ea

In addition to providing the lines to add to the BUILD files,
also provide a buildozer command that, when executed, attempts
to fix the BUILD files automatically.

Running buildozer requires the developer to install buildozer
as a one-time set up.

Sample output:

Alternatively, install buildozer and execute:
  $ buildozer 'add module_outs drivers/mfd/vexpress-sysreg.ko
drivers/gpu/drm/drm_cma_helper.ko
drivers/gpu/drm/pl111/pl111_drm.ko
drivers/virtio/virtio_mmio.ko
drivers/input/mouse/psmouse.ko
drivers/input/serio/ambakmi.ko
drivers/clk/versatile/clk-vexpress-osc.ko
drivers/bus/vexpress-config.ko
drivers/mmc/host/armmmci.ko' //common-modules/virtual-device:virtual_device_aarch64

Bug: none
Test: manual

Change-Id: I8b7ea944721975e4406be430e544d60580d9bae0

kernel_module does not have module_outs attribute.

Test: manual
Change-Id: I3a33dedb89e73d4ebf5f93324772f12d2b484d2d
Signed-off-by: Yifan Hong <elsk@google.com>

The --kasan flag enables kasan build. This automatically
implies --lto=none; if --lto is specified otherwise, build
fails.

Also add analysis test to ensure that the above is enforced.

Also add artifacts test to ensure that the CONFIG_KASAN
is set properly, even when it is used in combination with
other flags.

Test: TH
Bug: 236012429
Change-Id: I170d3cc8b672f51a24192e4df39704924fc38771

BYPASS_INCLUSIVE_LANGUAGE_REASON=CONFIG_UNUSED_KSYMS_WHITELIST
  is a key used in upstream kernel.

Test: bazel test //build/kernel/kleaf/tests
Bug: 236012429
Change-Id: Ic43a20180eacd5f345c0ebfe8af38d89e72d6722

Check that the LTO settings are configured properly.
Test: TH

Change-Id: I737dfb9610a97ac7f2e66f8e21e32a2b48c0dad8

Modify system_dlkm_image to operate in the same way as
vendor_dlkm_image, calling the build_utils scripts.

This is part of the change to build system_dlkm
as ext4 instead of erofs.

Bug: 236753150
Test: build with bazel,
 file ./out/mixed/dist/system_dlkm.img
 ./out/mixed/dist/system_dlkm.img: Linux rev 1.0 ext2 filesystem data,
 UUID=75130cbd-6ffb-4594-9084-8ce5bda658dc, volume name "system_dlkm" (extents) (large files) (huge files)

Signed-off-by: Andrew Chant <achant@google.com>
Change-Id: I8229be29b76ad8261a5ed79b6135e4867357a353

Group tests by the name of the rule or macro
they are testing.

Test: TH
Change-Id: I3a7a3a54efe8554b4a83e676d3870498d38197a2

Build system_dlkm as ext4 the same way android system does.
At the same time modify the build to mirror how vendor_dlkm
is built.

Test: build with BUILD_KERNEL=1, flashed and booted.

Signed-off-by: Andrew Chant <achant@google.com>
Bug: 236753150
Change-Id: If92c8f8426fd16636113bbdc09fd55001aeec6f0

Instead of specifying
  --in-dir=$ROOT_DIR/$KERNEL_DIR $(rel_path <src> $ROOT_DIR/$KERNEL_DIR)
use
  --in-dir=$ROOT_DIR <src>

This ensures that it works when $ROOT_DIR/$KERNEL_DIR
does not exist (because rel_path requires paths to exist).
This is the case in particular when the symbol list file
is outside of the $KERNEL_DIR for testing.

Test: see next CL

Change-Id: I4a0e8ef46d84c8006d9707167363b530f3aa16ca

Test: TH
Change-Id: I5b97f4e1e9141592c35c6140776b6925ea8f32d2

Add condition if we only want to build vendor_kernel_boot.img
when enabling BUILD_VENDOR_KERNEL_BOOT=1.

Bug: 237436066
Signed-off-by: Lucas Wei <lucaswei@google.com>
Change-Id: I4519ffa231e10dfc2c289da1f1ef23b8fcd8eeda

For aarch64:

The boot-img.tar.gz includes boot.img, boot-lz4.img,
boot-gz.img with kernel image: Image, Image.lz4,
Image.gz, respectively.

This change creates the tarballs for Kleaf.

For x86_64:

The boot.img will be used for GKI testing.

This is the Kleaf corresponding change to
a80c9ffa86c5919c10a73b47c4fe218d72a5838b
("ANDROID: Creating boot.img for x86_64 GKI")

Bug: 230428252
Bug: 233692305
Test: bazel build //common:kernel_dist
Test: bazel build //common:kernel_x86_64_dist
Change-Id: Ia1fe2dd356a6300d56f0a00109807b35a19abdad
Signed-off-by: Yifan Hong <elsk@google.com>

This function defines common external repositories
for Android platform and kernel.

Test: TH
Bug: 227705464

Change-Id: I5e2f5a811a128f20544512cc3cec5d9d1e72e968

Add missing comma.

Change-Id: I1f1e4db3be73f89722036d417d0dba218f5ec5fb
Signed-off-by: Yifan Hong <elsk@google.com>

Signed-off-by: Matthias Maennich <maennich@google.com>
Change-Id: Ibf15fd1f76cb8c16a886e2aedec9a57437cc7476

This generates better test.xml so the testing framework
can better understand the failures at test case level.

Test: manually fail the test, examine test.xml
Bug: 227705464
Change-Id: I61676b8bbea1c72176b28219b26ca805582c86dc

This makes it more clear that print_flags is expected to
be built with flags. Otherwise it will just show default
values.

Test: none
Change-Id: I98cd485fe0d4f1331fe09911af6b631fbe5b98c6

Symbol descriptions no longer include their type which in turn means
that reports about symbols gaining or losing their type are now
simpler. This commit adjusts the post-processing code to handle both
kinds of output.

Bug: 221022839
Change-Id: Id81f80644cf0759e9b781ced6d27a91f0dbfebff
Tested: LTO=thin build_abi.sh
Signed-off-by: Giuliano Procida <gprocida@google.com>

Add tests to check that symtypes/ is only generated
with kbuild_symtypes=true.

Test: bazel test //build/kernel/kleaf/tests/...
Bug: 233286182
Change-Id: I3dfb4bde8fa66ff295a7660da9f4d1dfc12c9cc8

Change 31a488ddd34499dcadc9c921a8f0daca08f17310
(Revert "ANDROID: modules: introduce the MODULE_SCMVERSION config")
disables CONFIG_MODULE_SCMVERSION temporarily. Until that
is re-enabled, disable tests on the existence of scmversion
for modules.

Bug: 236871190
Test: TH
Test: bazel test slider_tests --config=stamp

Change-Id: I75fce9f969d33ecbe1f407925324a66785029051

The test was previously not executed properly.

We don't care about testing vermagic on modules.
So just delete it.

Test: bazel test slider_tests --config=stamp
Bug: 236871757

Change-Id: I486b366b54f685c4ea0e467f04fb3b60ec13e1c1

Deduplicate configs that are shared between
aarch64 and aarch64_debug, and x86_64 and x86_64 debug.

Test: TH
Change-Id: Iee5fb40349d2c7caa5648da2147b9a4e65ceb339
Signed-off-by: Yifan Hong <elsk@google.com>

And delete the unused utils.removeprefix / removesuffix
functions.

Test: TH
Bug: 233247849
Change-Id: Ie2ff2f82d53140995dcbf5df11e491e22bcd434e

Revert submission 2127894-revert-2128555-kleaf-gki-artifacts-RDNWFQOUJK

Reason for revert: relanding changes
Reverted Changes:
I4b5d58ab4:Revert "kleaf: Add Image.gz."
I91a4dcaa1:Revert "kleaf: gki_artifacts takes kernel_build as...
Ia65c088bf:Revert "kleaf: Adding gki-info.txt, the GKI artifa...
I339190cf0:Revert "kleaf: Add testkey to gki_artifacts deps."...

Bug: 233730966
Change-Id: Iadfaa3117b3d358b23b0c22086f0a8a9b0306927

Revert submission 2127894-revert-2128555-kleaf-gki-artifacts-RDNWFQOUJK

Reason for revert: relanding changes
Reverted Changes:
I4b5d58ab4:Revert "kleaf: Add Image.gz."
I91a4dcaa1:Revert "kleaf: gki_artifacts takes kernel_build as...
Ia65c088bf:Revert "kleaf: Adding gki-info.txt, the GKI artifa...
I339190cf0:Revert "kleaf: Add testkey to gki_artifacts deps."...

Bug: 233730966
Change-Id: I7d24897f92b585125bd7b9360b4dc0003e179983

Revert submission 2127894-revert-2128555-kleaf-gki-artifacts-RDNWFQOUJK

Reason for revert: relanding changes
Reverted Changes:
I4b5d58ab4:Revert "kleaf: Add Image.gz."
I91a4dcaa1:Revert "kleaf: gki_artifacts takes kernel_build as...
Ia65c088bf:Revert "kleaf: Adding gki-info.txt, the GKI artifa...
I339190cf0:Revert "kleaf: Add testkey to gki_artifacts deps."...

Bug: 233730966
Change-Id: I7a06b1f11b05dc47c835cef2d7311835559098f1

Revert submission 2127894-revert-2128555-kleaf-gki-artifacts-RDNWFQOUJK

Reason for revert: relanding changes
Reverted Changes:
I4b5d58ab4:Revert "kleaf: Add Image.gz."
I91a4dcaa1:Revert "kleaf: gki_artifacts takes kernel_build as...
Ia65c088bf:Revert "kleaf: Adding gki-info.txt, the GKI artifa...
I339190cf0:Revert "kleaf: Add testkey to gki_artifacts deps."...

Bug: 233730966
Change-Id: Icb6ada13c0aa46fbbe47a6c23ddfdf1c70ae35dd

Test: none
Bug: 236012299
Change-Id: I0af34f79a41ae03dc0ac2715eefc3f352a872bee

Bug: 236618367
Test: TH
Change-Id: Icbe6dd9b6dd59ec65f1845601a984749d4a702ee