- Jan 25, 2024
-
-
Josip Sokcevic authored
If a project contains files not owned by the current user, remove will fail. In order to ensure repo sync continues to work, rename the affected project instead, and let user know about it. Bug: 321273512 Change-Id: I0779d61fc67042308a0226adea7d98167252a5d3 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/404372 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- Jan 05, 2024
-
-
Tomasz Wasilczyk authored
There are still some verbose messages (e.g. "remote: ...") when doing repo sync after a couple days. Let's hide them behind verbose flag. Bug: N/A Test: repo sync Change-Id: I1408472c95ed80d9555adfe8f92211245c03cf41 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/400855 Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Tested-by:
Tomasz Wasilczyk <twasilczyk@google.com> Commit-Queue: Tomasz Wasilczyk <twasilczyk@google.com>
-
- Jan 04, 2024
-
-
Mike Frysinger authored
Change-Id: Ie1a32cda67f94b0a2b3329b1be9e03dcbedf39cc Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/400917 Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Tested-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Mike Frysinger <vapier@google.com>
-
- Jan 03, 2024
-
-
Josip Sokcevic authored
Symbolic references need to be checked each time sync is called, not only for newly created repositories. For example, it is possible to change a project name to the already existing name, and that will result in a broken git setup without this patch: refs/ will still point to the old repository, whereas all objects will point to the new repository. Bug: 40013418 Change-Id: I596d29d182986804989f0562fb45090224549b0f Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/395798 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- Dec 20, 2023
-
-
Vitalii Dmitriev authored
After a6413f5d a GitCommandError is raised. Since there were no user identity were set up, it fails: - ReviewableBranchTests from test_project.py - ResolveRepoRev and CheckRepoRev from test_wrapper.py Test: ./run_tests Change-Id: Id7f5772afe22c77fc4c8f8f0b8be1b627ed42187 Signed-off-by:
Vitalii Dmitriev <vitalii.dmitriev@unikie.com> Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/398658 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Vitalii Dmitriev <dmit.vitalii@gmail.com> Commit-Queue: Vitalii Dmitriev <dmit.vitalii@gmail.com>
-
Vitalii Dmitriev authored
Before the change, repo normalizes the urls with a following format only: git@github.com:foo/bar It doesn't cover the following case: <remote name="org" fetch="git@github.com:org/" /> <project name="somerepo" remote="org" /> Results to: error: Cannot fetch somerepo from ssh://git@github.com/org/git@github.com:org/somerepo Current change fixes it by normalizing this format: git@github.com:foo Test: ./run_tests tests/test_manifest_xml.py Change-Id: I1ad0f5df0d52c0b7229ba4c9a4db4eecb5c1a003 Signed-off-by:
Vitalii Dmitriev <vitalii.dmitriev@unikie.com> Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/398337 Commit-Queue: Vitalii Dmitriev <dmit.vitalii@gmail.com> Tested-by:
Vitalii Dmitriev <dmit.vitalii@gmail.com> Reviewed-by:
Mike Frysinger <vapier@google.com>
-
- Dec 19, 2023
-
-
Josip Sokcevic authored
repo blocks indefinitely until trace collector receives trace events, which is not desired. This change adds a fixed timeout to connect and send operations. It is possible that some events will be lost. repo logs any failed trace operation. Bug: b/316227772 Change-Id: I017636421b8e22ae3fcbab9e4eb2bee1d4fbbff4 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/398717 Tested-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Jason Chang <jasonnc@google.com>
-
Mike Frysinger authored
Since git doesn't treat these as ssh:// URIs, we shouldn't either. Bug: https://g-issues.gerritcodereview.com/issues/40010331 Change-Id: I001f49be30395187cac447d09cb5a6c29e95768b Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/398517 Tested-by:
Mike Frysinger <vapier@google.com> Reviewed-by:
Jason Chang <jasonnc@google.com> Commit-Queue: Mike Frysinger <vapier@google.com>
-
- Dec 15, 2023
-
-
Peter Kjellerstedt authored
This simplifies check_python_version() since there is no point in trying to fall back to python3, as we are already running using some Python 3 interpreter. Change-Id: I9dfdd002b4ef5567e064d3d6ca98ee1f3410fd48 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/397759 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Peter Kjellerstedt <peter.kjellerstedt@axis.com> Commit-Queue: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
-
Peter Kjellerstedt authored
Change-Id: I1f5c691bf94f255442eea95e59ddd93db6213ad8 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/397758 Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Tested-by:
Peter Kjellerstedt <peter.kjellerstedt@axis.com>
-
- Dec 14, 2023
-
-
Peter Kjellerstedt authored
The EnvironmentError exception was changed to OSError in commit ae824fb2. Change-Id: I1b4ff742af409ec848131e82900e885c9f089f0c Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/397757 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Peter Kjellerstedt <peter.kjellerstedt@axis.com> Commit-Queue: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
-
- Dec 08, 2023
-
-
Tomasz Wasilczyk authored
Most times a repo sync after some time (week+) results in a bunch of messages, which are not very useful for average user: - discarding 1 commits - Deleting obsolete checkout. Bug: N/A Test: repo sync Change-Id: I881eab61f9f261e98f3656c09e73ddd159ce288c Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/397038 Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Tested-by:
Tomasz Wasilczyk <twasilczyk@google.com>
-
Josip Sokcevic authored
It's not a valid pylint config Change-Id: Ida480429a3a86637f26e9fc3a0d6fa2d225d952a Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/396921 Reviewed-by:
Scott Lee <ddoman@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Tested-by:
Josip Sokcevic <sokcevic@google.com>
-
- Dec 04, 2023
-
-
Orgad Shaneh authored
Modified in https://gerrit-review.googlesource.com/c/gerrit/+/394841. Change-Id: I381e48fbdb92b33454219dd9d945a1756e551a77 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/395577 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Orgad Shaneh <orgads@gmail.com> Commit-Queue: Orgad Shaneh <orgads@gmail.com> Reviewed-by:
Ernesto Rodriguez <guez30nesto@gmail.com>
-
- Nov 30, 2023
-
-
Matt Schulte authored
In the case of a project being removed from the manifest, and in the path in which the project used to exist, and symlink is place to another project repo will start to warn about partial syncs when a partial sync did not occur. Repro steps: 1) Create a manifest with two projects. Project a -> a/ and project b -> b/ 2) Run `repo sync` 3) Remove project b from the manifest. 4) Use `link` in the manifest to link all of Project a to b/ Bug: 314161804 Change-Id: I4a4ac4f70a7038bc7e0c4e0e51ae9fc942411a34 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/395640 Reviewed-by:
Gavin Mak <gavinmak@google.com> Tested-by:
Matt Schulte <matsch@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
- Nov 29, 2023
-
-
Duy Truong authored
Python 3.11 introduces PYTHONSAFEPATH and the -P flag which, if enabled, does not prepend the script's directory to sys.path by default. This breaks repo because main.py expects its own directory to be part of Python's import path. This causes problems with tools that add PYTHONSAFEPATH to python programs, most notably Bazel. We will simply prepend main.py's path to PYTHONPATH instead. Bug: 307767740 Change-Id: I94f3fda50213e450df0d1e2df6a0b8b597416973 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/391236 Tested-by:
Duy Truong <duytruong@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com>
-
- Nov 20, 2023
-
-
Josip Sokcevic authored
When a repo client is initialized with --standalone-manifest, it doesn't have merge branch defined. This results in mergeBranch being None. Bug: b/308025460 Change-Id: Iebceac0976e5d3adab5300bd8dfc76744a791234 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/393716 Tested-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- Nov 15, 2023
-
-
Guillaume Micouin-Jorda authored
Change-Id: I58f91c6b0db631bb7f55164f41d11d3a349ac94f Signed-off-by:
Guillaume Micouin-Jorda <gmicouin@netcourrier.com> Signed-off-by:
Hadamik Stephan <Stephan.Hadamik@continental-corporation.com> Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/392020 Reviewed-by:
Ben PUJOL <pujolbe@gmail.com> Reviewed-by:
LaMont Jones <lamontjones@google.com> Tested-by:
Roberto Prado <roberto.prado.c@gmail.com> Commit-Queue: Roberto Prado <roberto.prado.c@gmail.com> Tested-by:
LaMont Jones <lamontjones@google.com> Reviewed-by:
Roberto Prado <roberto.prado.c@gmail.com>
-
- Nov 13, 2023
-
-
Josh Bartel authored
This updates RepoLogger.log_aggregated_errors to print out the error message the RepoExitError when there is not a list of aggregated errors. Previously it would log out: ======================================================================= Repo command failed: ManifestParseError This told us what class of error occurred but missed the helpful error message that developers put in the error. After this change it will now print out the error message: ======================================================================= Repo command failed: ManifestParseError error parsing manifest /path/to/manifest.xml: no element found: line 197, column 0 Change-Id: I4805540fddb5fa9171dbc8912becfa7fdfb1ba67 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/392614 Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Tested-by:
Joshua Bartel <josh.bartel@garmin.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com>
-
Jason R. Coombs authored
Avoids treating the operation as if it were acting on a bare repository, thereby triggering failures when the Git client is configured with `safe.bareRepository=explicit`. Repo doesn't actually use a bare repository, but pointing at the gitdir acts as if it had. Bug: 307559774 Change-Id: I2c142275b2726a59526729c0b2c54faf728f125d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/391554 Commit-Queue: Jason R. Coombs <jaraco@google.com> Tested-by:
Jason R. Coombs <jaraco@google.com> Tested-by:
Emily Shaffer <emilyshaffer@google.com> Reviewed-by:
Emily Shaffer <emilyshaffer@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com>
-
- Nov 09, 2023
-
-
Emily Shaffer authored
The superproject is initialized as a bare repo in Superproject:_Init(). That means that later operations must treat it as a bare repository, specifying the gitdir and setting 'bare' appropriately when launching GitCommand()s. It's also OK not to specify cwd here because GitCommand() will drop cwd if bare == True anyways. With this change, it's possible to run `repo init` and `repo sync` with the Git config 'safe.bareRepository' set to 'explicit'. This config strengthens Git's security posture against embedded bare repository attacks like https://github.com/justinsteven/advisories/blob/main/2022_git_buried_bare_repos_and_fsmonitor_various_abuses.md. Bug: b/227257481 Change-Id: I954a64c6883d2ca2af9c603e7076fd83b52584e9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389794 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Jason R. Coombs <jaraco@google.com> Tested-by:
Emily Shaffer <emilyshaffer@google.com> Reviewed-by:
Emily Shaffer <emilyshaffer@google.com> Commit-Queue: Jason R. Coombs <jaraco@google.com>
-
- Nov 08, 2023
-
-
Michael Kelly authored
Currently we don't deal with schema-less URIs like `git@github.com:foo` at all resulting in a scenario where we append them to the manifest repo URL. In order to deal with this, we munge both the manifest URL and the fetch URL into a format we like and proceed with that. Bug: https://g-issues.gerritcodereview.com/issues/40010331 Change-Id: I7b79fc4ed276630fdbeb235b94e327b172f0879b Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/386954 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Michael Kelly <mkelly@arista.com> Commit-Queue: Mike Frysinger <vapier@google.com>
-
- Nov 06, 2023
-
-
LuK1337 authored
This lets us see manifest parsing error messages again. Change-Id: I2d90b97cfb50e4520f79e75fa0d648c373b49e98 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/391477 Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Łukasz Patron <priv.luk@gmail.com> Tested-by:
Łukasz Patron <priv.luk@gmail.com>
-
- Nov 01, 2023
-
-
Jason R. Coombs authored
Change-Id: I41371feb88c85e9da0656b9fab04057c22d1dcf4 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/391514 Tested-by:
Jason R. Coombs <jaraco@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Jason R. Coombs <jaraco@google.com>
-
- Oct 31, 2023
-
-
Jason R. Coombs authored
- Bump minimum version to Python 3.6. - Use f-strings in a lot of places. Change-Id: I2aa70197230fcec2eff8e7c8eb754f20c08075bb Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389034 Tested-by:
Jason R. Coombs <jaraco@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Jason R. Coombs <jaraco@google.com>
-
- Oct 25, 2023
-
-
Daniel Kutik authored
Found via pylint: W0231: __init__ method from base class 'Transport' is not called (super-init-not-called) Just fixed for code correctness and to avoid potential future bugs. Change-Id: Ie1e723c2afe65d026d70ac01a16ee7a40c149834 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390676 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Daniel Kutik <daniel.kutik@lavawerk.com> Commit-Queue: Daniel Kutik <daniel.kutik@lavawerk.com>
-
- Oct 24, 2023
-
-
Daniel Kutik authored
Change-Id: I211776a493cad4b005c6e201833e9700def2feb9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390657 Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Daniel Kutik <daniel.kutik@lavawerk.com> Tested-by:
Daniel Kutik <daniel.kutik@lavawerk.com>
-
Jason Chang authored
Change-Id: Ice4f4cc745cbac59f356bd4ce1124b6162894e61 Bug: b/113935847 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390434 Tested-by:
Jason Chang <jasonnc@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Jason Chang <jasonnc@google.com>
-
- Oct 23, 2023
-
-
Josip Sokcevic authored
When a new shared project is added to manifest, there's a short window where objects can be deleted that are used by other projects. To close that window, set preciousObjects during git init. For non-shared projects, repo should correct the state in the same execution instance. Bug: 288102993 Change-Id: I366f524535ac58c820d51a88599ae2108df9ab48 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390234 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Tested-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com>
-
- Oct 21, 2023
-
-
Jason R. Coombs authored
In Python 3, these exceptions were merged into OSError, so switch everything over to that. Change-Id: If876a28b692de5aa5c62a3bdc8c000793ce52c63 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390376 Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Tested-by:
Mike Frysinger <vapier@google.com>
-
Jason R. Coombs authored
Change-Id: I86ebb8c5a9dc3752e8a25f4b11b64c5be3a6429e Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390375 Tested-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com>
-
Jason R. Coombs authored
Change-Id: Ie34ac33ada7855945c77238da3ce644f8a9f8306 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390374 Tested-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com>
-
- Oct 20, 2023
-
-
Chris Allen authored
When parsing the manifest XML, the code looks for a top level DOM node named "manifest". However, it doesn't check that it's an element type node so if there is also an XML document type declaration node present (which has the same name as the root element) then it selects the wrong node and hence you end up with no projects defined at all. Change-Id: I8d101caffbbc2a06e56136ff21302e3f09cfc96b Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390357 Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Chris Allen <chris.allen@arm.com> Commit-Queue: Chris Allen <chris.allen@arm.com>
-
Jason R. Coombs authored
Change-Id: I4f9cb27d89241d3738486764817b51981444a903 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390274 Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Tested-by:
Mike Frysinger <vapier@google.com>
-
Daniel Kutik authored
Test: tox Change-Id: Ifc0dc089deef5a3b396d889c9ebfcf8d4f007bf2 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390360 Tested-by:
Daniel Kutik <daniel.kutik@lavawerk.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Daniel Kutik <daniel.kutik@lavawerk.com>
-
Roberto Vladimir Prado Carranza authored
Fix: https://issues.gerritcodereview.com/issues/40015442 Change-Id: I7fb6c50cf2e438b21181ce1a5893885f09b9ee2b Signed-off-by:
Roberto Vladimir Prado Carranza <roberto.prado.c@gmail.com> Signed-off-by:
Guillaume Micouin-Jorda <gmicouin@netcourrier.com> Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/385995 Commit-Queue: Mike Frysinger <vapier@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Reviewed-by:
Jerome Couto <jerome.couto@renault.com>
-
Mike Frysinger authored
Bug: 302871152 Change-Id: Ie7a0219e7ac582cd25c2bc5fb530e2c03bcbcc6e Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390034 Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Mike Frysinger <vapier@google.com> Tested-by:
Mike Frysinger <vapier@google.com>
-
Mike Frysinger authored
Bug: 302871152 Change-Id: I39636d73a6e1d69efa8ade74f75c5381651e6dc8 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390054 Commit-Queue: Mike Frysinger <vapier@google.com> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Tested-by:
Mike Frysinger <vapier@google.com>
-
- Oct 17, 2023
-
-
Jason R. Coombs authored
When running the tests in my environment, tests that derived from `test_wrapper.GitCheckoutTestCase` would fail on commit or tag due to incomplete or incorrect gpg config. Ideally, the tests should not be dependent on the user's git config. This change ensures $HOME (or Windows equivalent) is replaced for the session. Bug: 302797407 Change-Id: Ib42b712dd7b6602fee6e18329a8c6d52fb9458b9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/388235 Tested-by:
Jason R. Coombs <jaraco@google.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Commit-Queue: Jason R. Coombs <jaraco@google.com>
-
Daniel Kutik authored
adding the recently released python 3.12 to our list of test environments. Change-Id: I05ec0129ad29c16fff65ddfb389f251571f811a2 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389754 Commit-Queue: Daniel Kutik <daniel.kutik@lavawerk.com> Reviewed-by:
Mike Frysinger <vapier@google.com> Tested-by:
Daniel Kutik <daniel.kutik@lavawerk.com>
-