Skip to content
Snippets Groups Projects
  1. Sep 30, 2005
  2. Sep 23, 2005
  3. Sep 17, 2005
    • Jeff Dike's avatar
      [PATCH] uml: preserve errno in error paths · b4fd310e
      Jeff Dike authored
      
      The poster child for this patch is the third tuntap_user hunk.  When an ioctl
      fails, it properly closes the opened file descriptor and returns.  However,
      the close resets errno to 0, and the 'return errno' that follows returns 0
      rather than the value that ioctl set.  This caused the caller to believe that
      the device open succeeded and had opened file descriptor 0, which caused no
      end of interesting behavior.
      
      The rest of this patch is a pass through the UML sources looking for places
      where errno could be reset before being passed back out.  A common culprit is
      printk, which could call write, being called before errno is returned.
      
      In some cases, where the code ends up being much smaller, I just deleted the
      printk.
      
      There was another case where a caller of run_helper looked at errno after a
      failure, rather than the return value of run_helper, which was the errno value
      that it wanted.
      
      Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
      Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      b4fd310e
    • Jeff Dike's avatar
      [PATCH] uml: Remove a useless include · d9f0d915
      Jeff Dike authored
      
      linux/inet.h isn't needed, and on my system, is empty.
      
      Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
      Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      d9f0d915
    • Jeff Dike's avatar
      [PATCH] uml: Remove an unused file · edcc2205
      Jeff Dike authored
      
      This removes a file which is no longer used.
      
      Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
      Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      edcc2205
    • Jeff Dike's avatar
      [PATCH] uml: breakpoint an arbitrary thread · 3eddddcf
      Jeff Dike authored
      
      This patch implements a stack trace for a thread, not unlike sysrq-t does.
      The advantage to this is that a break point can be placed on showreqs, so that
      upon showing the stack, you jump immediately into the debugger.  While sysrq-t
      does the same thing, sysrq-t shows *all* threads stacks.  It also doesn't work
      right now.  In the future, I thought it might be acceptable to make this show
      all pids stacks, but perhaps leaving well enough alone and just using sysrq-t
      would be okay.  For now, upon receiving the stack command, UML switches
      context to that thread, dumps its registers, and then switches context back to
      the original thread.  Since UML compacts all threads into one of 4 host
      threads, this sort of mechanism could be expanded in the future to include
      other debugging helpers that sysrq does not cover.
      
      Note by jdike - The main benefit to this is that it brings an arbitrary thread
      back into context, where it can be examined by gdb.  The fact that it dumps it
      stack is secondary.  This provides the capability to examine a sleeping
      thread, which has existed in tt mode, but not in skas mode until now.
      
      Also, the other threads, that sysrq doesn't cover, can be gdb-ed directly
      anyway.
      
      Signed-off-by: default avatarAllan <Graves&lt;allan.graves@gmail.com>
      Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
      Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      3eddddcf
  4. Sep 05, 2005
  5. Aug 27, 2005
    • Al Viro's avatar
      [PATCH] mmaper_kern.c fixes [buffer overruns] · 6a029a90
      Al Viro authored
      
       - copy_from_user() can fail; ->write() must check its return value.
      
       - severe buffer overruns both in ->read() and ->write() - lseek to the
         end (i.e.  to mmapper_size) and
      
      	if (count + *ppos > mmapper_size)
      		count = count + *ppos - mmapper_size;
      
         will do absolutely nothing.  Then it will call
      
      	copy_to_user(buf,&v_buf[*ppos],count);
      
         with obvious results (similar for ->write()).
      
         Fixed by turning read to simple_read_from_buffer() and by doing
         normal limiting of count in ->write().
      
       - gratitious lock_kernel() in ->mmap() - it's useless there.
      
       - lots of gratuitous includes.
      
      Signed-off-by: default avatarAl Viro <viro@parcelfarce.linux.theplanet.co.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      6a029a90
  6. Jul 29, 2005
  7. Jul 27, 2005
  8. Jul 14, 2005
  9. Jul 08, 2005
  10. Jun 25, 2005
  11. Jun 22, 2005
    • Paolo 'Blaisorblade' Giarrusso's avatar
      [PATCH] uml: complete hw_controller_type->release conversion · faec1e99
      Paolo 'Blaisorblade' Giarrusso authored
      
      This occurrence of free_irq_by_irq_and_dev() was missed when converting UML
      to the use of hw_controller_type->release.
      
      Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      faec1e99
    • Paolo 'Blaisorblade' Giarrusso's avatar
      [PATCH] uml: add and use generic hw_controller_type->release · dbce706e
      Paolo 'Blaisorblade' Giarrusso authored
      
      With Chris Wedgwood <cw@f00f.org>
      
      Currently UML must explicitly call the UML-specific
      free_irq_by_irq_and_dev() for each free_irq call it's done.
      
      This is needed because ->shutdown and/or ->disable are only called when the
      last "action" for that irq is removed.
      
      Instead, for UML shared IRQs (UML IRQs are very often, if not always,
      shared), for each dev_id some setup is done, which must be cleared on the
      release of that fd.  For instance, for each open console a new instance
      (i.e.  new dev_id) of the same IRQ is requested().
      
      Exactly, a fd is stored in an array (pollfds), which is after read by a
      host thread and passed to poll().  Each event registered by poll() triggers
      an interrupt.  So, for each free_irq() we must remove the corresponding
      host fd from the table, which we do via this -release() method.
      
      In this patch we add an appropriate hook for this, and remove all uses of
      it by pointing the hook to the said procedure; this is safe to do since the
      said procedure.
      
      Also some cosmetic improvements are included.
      
      This is heavily based on some work by Chris Wedgwood, which however didn't
      get the patch merged for something I'd call a "misunderstanding" (the need
      for this patch wasn't cleanly explained, thus adding the generic hook was
      felt as undesirable).
      
      Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
      CC: Ingo Molnar <mingo@redhat.com>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      dbce706e
  12. Jun 14, 2005
  13. Jun 08, 2005
  14. May 28, 2005
  15. May 20, 2005
  16. May 05, 2005
  17. May 01, 2005
  18. Apr 16, 2005
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      v2.6.12-rc2
      1da177e4
Loading