Skip to content
Snippets Groups Projects
Commit ceb09959 authored by Takashi Iwai's avatar Takashi Iwai Committed by Jonathan Solnit
Browse files

BACKPORT: ALSA: timer: Fix race between read and ioctl


The read from ALSA timer device, the function snd_timer_user_tread(),
may access to an uninitialized struct snd_timer_user fields when the
read is concurrently performed while the ioctl like
snd_timer_user_tselect() is invoked.  We have already fixed the races
among ioctls via a mutex, but we seem to have forgotten the race
between read vs ioctl.

This patch simply applies (more exactly extends the already applied
range of) tu->ioctl_lock in snd_timer_user_tread() for closing the
race window.

Reported-by: default avatarAlexander Potapenko <glider@google.com>
Tested-by: default avatarAlexander Potapenko <glider@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
(cherry picked from commit d11662f4)
Signed-off-by: default avatarConnor O'Brien <connoro@google.com>
Bug: 62201221

Change-Id: I67a3b5153c39ce9f6d7571b5aa8faabe5e3dbb83
parent c4fbca81
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment