Skip to content
Snippets Groups Projects
user avatar
Arend van Spriel authored
commit 8f44c9a4 upstream.

The lower level nl80211 code in cfg80211 ensures that "len" is between
25 and NL80211_ATTR_FRAME (2304).  We subtract DOT11_MGMT_HDR_LEN (24) from
"len" so thats's max of 2280.  However, the action_frame->data[] buffer is
only BRCMF_FIL_ACTION_FRAME_SIZE (1800) bytes long so this memcpy() can
overflow.

	memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],
	       le16_to_cpu(action_frame->len));

Bug: 64258073
(cherry picked from commit 4c7021c2)
Fixes: 18e2f61d ("brcmfmac: P2P action frame tx.")
Reported-by: default avatar"freenerguo(郭大兴)" <freenerguo@tencent.com>
Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Change-Id: I6cfdd327070c45667267f4f8bdb37b68508cb84c
f64dc5de
Name Last commit Last update