* Update GitHub workflow to use ubuntu-22.04 instead of ubuntu-latest

This change is made to avoid issues related to the ongoing Ubuntu upgrade in the CI workflow.

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

While packing shared buffer with names of all shared objects present
in custom DSP_LIBRARY_PATH , their is a possibility of buffer overflow
if the shared object names are exceeding the desired limit.The change
makes sure the limit is not exceeded thus avoiding buffer overflow.
Also, the buffer was allocated with 1KB memory which might fall short
to accomodate all the needed shared object names so, increasing this
size to 2KB.

Signed-off-by: Anand Kulkarni <quic_anankulk@quicinc.com>

Handles are allocated while configuring the staticPD information;
however, these handles are not used to communicate with the DSP.
Therefore, there is no point in allocating these handles; instead,
return predefined values for these handles.

Signed-off-by: Abhishek Singh <abhishes@qti.qualcomm.com>

* Currently, the dev node is checked before adding the watcher FD. If
the dev node is created between this check and the addition of the
watcher FD, it will be missed by the poll. Therefore, check the dev
node’s existence after adding the watcher FD. Additionally, read all
events once the poll completes to ensure no events are missed.

* define the local pointer variable properly.

---------

Signed-off-by: Abhishek <quic_abhishes@quicinc.com>

The library is looking for get_device_fd definition which
is not available. This is causing shared object loading failure.
Define get_device_fd to fix this issue.

Fixes: https://github.com/quic/fastrpc/issues/121


Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Session close call is used by capability and context management
functions. The handling should be in such a way that capability
request should not close the device node if the PD is established.
Handle session close correctly.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Currenly check for wait_count is happening before updating
the packet counters due to optimizations. This will result
in HLOS not sending signal properly. This fix will ensure
that wait_count is only checked after updating the packet
counters.

Signed-off-by: ANANDU KRISHNAN E <quic_anane@quicinc.com>

Add TID for RPC invoke timer. During callback, TID is printed along
with handle and SC info. This helps to understand which thread is
taking time for the invoke.

Signed-off-by: ANANDU KRISHNAN E <quic_anane@quicinc.com>

If multidomain call is not supported by DSP, both root PD
and user PD returns different error codes. Handle fallback for
both error codes.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Version fastrpc libraries following semantic versioning.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Currently fallback to non domain static handle calls is being done
when we recieve module not supported error from DSP AEE_NOSUCHMOD.
But, if module is not present the error code is being converted to
AEE_ERPC. Replace fallback error code from AEE_NOSUCHMOD to
AEE_ERPC.

Signed-off-by: karthik sanagavarapu <quic_kartsana@quicinc.com>

Fix code scanning alert no.1: signed overflow
Fix code scanning alert no.2: Too few arguments to formatting function
Fix code scanning alert no.3: Too few arguments to formatting function
Fix code scanning alert no.4: Time-of-check time-of-use filesystem race condition

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

Update copyright for newly added source and header files.

Change-Id: I66d7b9c9066a770cc0a661bc386f9c642d70819d
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Use typedef structs in listener and fastrpc_notif modules. Fix pointer
declaration style and indentation in multiple files.

Change-Id: I4496b0b01287422f924650e21e5ed8e04a7d4362
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Add changes to support new fastrpc multi-domain context feature, which
allows clients to create a 'fastrpc context' associated with multiple
remote sessions.

Also, enable creation of dspqueue on a multidomain context, using which
clients can communicate with multiple remote sessions using existing
dspqueue apis.

Change-Id: I70dcce1cb5970ec391a1e153ad3be59173753ef9
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Add fastrpc interfaces for clients to create and destroy multidomain
contexts and multi-domain dspqueues.

Change-Id: Ie4a3dd6ce126cadfd5e01be412b33c9c280a35ec
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Convert all apps mem related arrays declared statically based on
number of effective domain ids to dynamic hash-tables with the
effective domain id as the key.

Change-Id: I23c44ab7a790dcf8ecb1860dbaeceae5efd4a042
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Convert notif array to hash-table to handle dynamic number of domains.

Change-Id: Id81df5da4b7b8d7d9be09a44e37eb21265c1cd29
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Fix pointer declaration style

Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

As the number of domains can change dynamically on each target, the
maintenance of listener info is not scalable. Instead, convert it to
a hash-table.

Change-Id: I6a862a77c7efb15d9c241243a132a2348e373966
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

For easier maintainability, use macros for all operations involving
all domain ids and effective domain ids - like conversion, traversal
and validation.

Change-Id: Ib9b967b80e0bb850fb1dcbf67a900aaebf2ee81c
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

set the untrusted input value of the expression to an intermediate environment variable and avoid code and command injection vulnerabilities in GitHub workflows

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

Set up CodeQL analysis to run on push and pull request events for both main and development branches.
Include static analysis for C language using CodeQL.

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

In case PM QoS request is not supported, there is no need to retry
the call every 100ms. Bail out from the loop in case PM QoS is not
supported.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

For multi session run the user will pass extended domain which will
make a call to driver to support legacy 2 session feature. As upstream
driver doesnot support the legacy mode, this call returns failure.
Return success from this call if the request is for multisession
support.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>

Once the SSR notification is received, clients are supposed to close
all open handles, which closes the current session. After SSR is
completed, clients can open a new session and continue. To close the
dspqueue handle, dspqueue close call should complete successfully.
However, the dspqueue close contains APIs which will make IOCTL
calls that fail with the AEE_ECONNRESET error during SSR. These
errors prevent dspqueue handle from closing successfully.
Don’t call APIS wiht IOCTLs in dspqueue close if SSR is ongoing.
Also Update dspsignal and dspqueue functions to return
AEE_ECONNRESET in case of SSR

Signed-off-by: ANANDU KRISHNAN E <quic_anane@quicinc.com>

There are some dynamic modules which gets flashed along with DSP,
these modules are generally pushed to /usr/lib/dsp/ path. Need to
add this path to DSP search path so the files can be opened when
requested by DSP.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

When daemon is trying to attach to DSP PD, it is checking for the
secure device node availability of that particular domain. Add
CDSP1 device node information to support CDSP1 daemon.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Problem: The absence of the No_HAL flag is causing the daemons to malfunction.

Fix: Adding NO_HAL to daemons binary

Signed-off-by: karthik sanagavarapu <quic_kartsana@quicinc.com>

FastRPC library supports 4 domains. There are some products
where a new domain, CDSP1, is supported. Add changes to support
CDSP1 domain.

Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>

Update gitcompile with execute permissions. Also correct the
information in README file.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Currently in case of failure of static domain rpc calls
we are falling back to non domain calls. The fallback
to non domain calls should only happen when support for
static domain based rpc calls is not present. Add proper
check in error cases for static domain rpc calls.

Signed-off-by: Abhinav Parihar <quic_parihar@quicinc.com>

Merging the missing commits from branch 'development' into 'main'

Merging the missing commits from branch 'development' into 'main'

Currently we are trying to fetch handle_info information
from remote handles which doesn't point to the correct
memory locations leading to segmentation faults.
For non domain calls user communicates via remote handle
instead of local handles. These user copy of remote handles
cannot be used to get handle_info related information and
will lead to faults.

Signed-off-by: Abhinav Parihar <quic_parihar@quicinc.com>

In scenarios where static domain handle support is not
available, wrong handle info is being passed to
fastrpc_update_module_list function. This leads to wrongful
updation of domainsCount variable which is meant to keep
count of dynamic domain handles. The corrupted domainsCount
variable leads to premature exit of user process.

Signed-off-by: Abhinav Parihar <quic_parihar@quicinc.com>

Add information about the steps to follow to contribute to fastrpc
project.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>

Signed-off-by: Tharun Kumar Merugu <quic_mtharu@quicinc.com>