-
sent/20240412-linux-next-24-04-11-sc8280xp-cci-compat-string-fix-e22a0e9ec83f-v12309069c · ·
dt-bindings: i2c: qcom-cci: Fix missing sc8280xp compatible Initially I added a compat string to yaml and driver for sc8280xp but, it was incomplete and wrong so I asked for a revert. Subsequent to posting the compat string I had posted dtsi changes to sc8280xp to add in the CCI, forgetting to follow up on the compat revert. I then completely forgot about the compat string and worse still misremembered the whole reasoning behind it. This one patch series cleans up the mess. - The fallback compat qcom,msm8916-cci hooks the driver. Since there are no driver changes specific to sc8280xp we don't need to add yet another entry to the CCI driver. - The compat string qcom,sc8280xp-cci is additionally declared in the dts -> compat = "qcom,msm8916-cci", "qcom,sc8280xp-cci"; The sc8280xp-cci will match the yaml and enforce constraints. - The yaml entry for qcom,sc8280xp-cci constrains the list of clocks which is specific to sc8280xp-cci Result: - No new redundant compat string in the CCI driver - DTS is unchanged - YAML expanded to capture missing string - BOD suitably contrite Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-04-11-sc8280xp-cci-compat-string-fix?ref_type=heads To: wsa@kernel.org To: Loic Poulain <loic.poulain@linaro.org> To: Robert Foss <rfoss@kernel.org> To: Andi Shyti <andi.shyti@kernel.org> To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk+dt@kernel.org> To: Conor Dooley <conor+dt@kernel.org> Cc: linux-i2c@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Bryan O'Donoghue (1): dt-bindings: i2c: qcom-cci: Document sc8280xp compatible .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) --- base-commit: 4118d9533ff3a5d16efb476a0d00afceecd92cf5 change-id: 20240412-linux-next-24-04-11-sc8280xp-cci-compat-string-fix-e22a0e9ec83f Best regards,
-